Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad answer to (procedures treating cataracts) #83

Open
cbizon opened this issue Jan 28, 2022 · 4 comments
Open

Bad answer to (procedures treating cataracts) #83

cbizon opened this issue Jan 28, 2022 · 4 comments

Comments

@cbizon
Copy link
Contributor

cbizon commented Jan 28, 2022

Query:
https://github.com/NCATSTranslator/testing/blob/main/ars-requests/not-none/1.2/cataractTreatment.json
Results:
https://arax.ncats.io/?r=1ef9d36e-dd59-4248-b0fc-fb588a387010

The query is "procedure that treats cataracts". RTX KG2 is retuning a bunch of answers relating to kidneys, with very general (low IC) terms for the procedure (e.g. "Therapeutic Procedure").

Then AC happily says, "hey what do a bunch of kidney diseases and eye diseases have in common?" and finds some garbage high level node like "disease by anatomical region" and merges everything together.

Then the ranker looks at that, says "great, so many nodes!" and gives a high score.

So I think that there are multiple things that could be done here, affecting different components:

  1. RTX I think shouldn't be returning those results, I have an issue into them
  2. Should strider try to verify the subclass of and filter in cases when it thinks the KPs are wrong? How much trust vs verify do we need in strider?
  3. AC should probably be tuned; I doubt that disease by anatomical feature should ever be considered an enrichment?
  4. Ranker should downweight this answer based on the low IC of the "disease by anatomical feature"
@cbizon
Copy link
Contributor Author

cbizon commented Jan 28, 2022

@kennethmorton thoughts?

@cbizon
Copy link
Contributor Author

cbizon commented Jan 28, 2022

After discussion on aragorn today, we decided the following:

  1. Strider really has to trust the KPs. If they give us errors, we're just in trouble, but it's going to be too slow to double check everything all the time
  2. We need to go back to AC and check the denominators, the disease by anatomy is not a good grouping. We have an issue about this already.
  3. Ranker should make use of node information content to modulate scores.

@cbizon
Copy link
Contributor Author

cbizon commented Jan 28, 2022

  1. We need to start a collection of queries to keep an eye on.

@cbizon
Copy link
Contributor Author

cbizon commented Sep 8, 2022

I don't think that this is an aragorn issue per-se, but holding it open here to coordinate some of the other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant