Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KL/AT are both required attributes, so if they are not present for an edge when receiving it from a KP, we should probably log it and set them both to not_provided so that we can then post an issue for that KP. #453

Open
maximusunc opened this issue Jul 23, 2024 · 0 comments
Open

KL/AT are both required attributes, so if they are not present for an edge when receiving it from a KP, we should probably log it and set them both to not_provided so that we can then post an issue for that KP. #453

maximusunc opened this issue Jul 23, 2024 · 0 comments

Comments

@maximusunc
Copy link
Collaborator 

          This looks good now. KL/AT are both required attributes, so if they are not present for an edge when receiving it from a KP, we should probably log it and set them both to `not_provided` so that we can then post an issue for that KP. That's beyond the scope of this PR though.

Originally posted by @uhbrar in #452 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maximusunc