Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paths to renci python image #452

Merged
merged 11 commits into from
Jul 23, 2024
Merged

Update paths to renci python image #452

merged 11 commits into from
Jul 23, 2024

Conversation

maximusunc
Copy link
Collaborator

No description provided.

@maximusunc maximusunc requested a review from uhbrar July 22, 2024 17:53
Copy link
Collaborator

@kennethmorton kennethmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

strider/trapi.py Outdated Show resolved Hide resolved
strider/trapi.py Outdated Show resolved Hide resolved
@maximusunc maximusunc requested a review from uhbrar July 23, 2024 13:22
Copy link
Collaborator

@uhbrar uhbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. KL/AT are both required attributes, so if they are not present for an edge when receiving it from a KP, we should probably log it and set them both to not_provided so that we can then post an issue for that KP. That's beyond the scope of this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants