-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More documentation #203
More documentation #203
Conversation
aad2f0f
to
7c2c435
Compare
6a96bd4
to
97b45fb
Compare
This PR looks good except that the If you also don't know how it works I can dive in and learn about it but I thought I would ask. |
@davefol I made a milestone for cleaning up dead code so feel free to create issues and link them to it |
perfect is the enemy of good yada yada. I'll make an issue for updaating PLANNING_OVERVIEW.md and tentatively assign @uhbrar to it. I don't want it to block this PR because this is a lot of really good stuff. |
97b45fb
to
a6b8749
Compare
I think I might have the clearest (remaining) picture of the query planning algorithm. I'll put this on my list for documentation. From my current understanding the algorithm we have is pretty solid, and shouldn't need to be overhauled for a while, but we might want to add a few bells and whistles. However those bells and whistles don't offer as much as optimizations elsewhere right now. |
I'll add @kennethmorton to the assigned members for issue #321 |
I'll take a look at it as well, although I don't actually know how it works precisely, except for some parts that Patrick shared with me before he left. That being said, besides Kenny, I might have the best chance of getting it fully figured out, and it'll be a good opportunity to look through the code and learn about it for me anyway. |
d5d9490
to
390b4ab
Compare
390b4ab
to
699acc8
Compare
Added high level documentation overviews for execution and planning. These are good for onboarding onto the project. Couldn't quite finish the planning documentation but got pretty close to done.