Add pinnedness planning #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkwang
force-pushed
the
pinnedness-planning
branch
from
a805792 to
2ec72f7
Compare
maximusunc
requested changes
Sep 30, 2021
strider/query_planner.py
Outdated
| def get_pinnedness(qgraph, qnode_id): | ||
| """Get pinnedness of each node.""" | ||
| adjacency_mat = get_adjacency_matrix(qgraph) | ||
| return -_get_pinnedness_recursively( |
There was a problem hiding this comment.
Why is there a minus sign here? I think it's easy to miss and should be more obvious.
There was a problem hiding this comment.
I modified some naming/documentation to try and make this more readable.
strider/query_planner.py
Outdated
| num_ids = ids | ||
| A[qnode_id][qnode_id] = num_ids | ||
| for qedge in qgraph["edges"].values(): | ||
| A[qedge["subject"]][qedge["object"]] = True |
There was a problem hiding this comment.
What about self-edges?
There was a problem hiding this comment.
Good catch... this will break somewhat if self edges are present, and also will not work as we perhaps hope if there are multi-edges. I think it can be made to work nicely, it will just take a little more thought.
Also clarify that we're computing log(n)
patrickkwang
force-pushed
the
pinnedness-planning
branch
from
d087628 to
4590182
Compare
maximusunc
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.