Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter and fetcher fixes #439

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Filter and fetcher fixes #439

merged 9 commits into from
Dec 14, 2023

Conversation

maximusunc
Copy link
Collaborator

No description provided.

@maximusunc maximusunc requested a review from uhbrar December 14, 2023 18:40
uhbrar
uhbrar approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@uhbrar uhbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, however I think this shows that we need to have a more robust test suite. We should consider what cases our current testing fails to cover.

@maximusunc maximusunc merged commit 4fa90de into master Dec 14, 2023
4 checks passed
@maximusunc maximusunc deleted the filter_and_fetcher_fixes branch December 14, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhbrar uhbrar uhbrar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximusunc @uhbrar