What happens if the CASE transformation is always applied

(just looking at NullSemanticsQuerySqliteTest)
ranma42 · Jul 27, 2024 · ecdd12e · ecdd12e
1 parent 4c3a542
commit ecdd12e
Show file tree

Hide file tree

Showing 2 changed files with 241 additions and 63 deletions.
diff --git a/src/EFCore.Relational/Query/SqlNullabilityProcessor.cs b/src/EFCore.Relational/Query/SqlNullabilityProcessor.cs
@@ -1820,9 +1820,7 @@ private SqlExpression RewriteNullSemantics(
         // a == b && some_column IS NOT NULL
         // as we consider it simpler than the CASE expression; additionally it
         // might take advantage of indexes on some_column, on a and/or on b.
-        if (leftNullable && rightNullable
-            || leftIsNull is SqlUnaryExpression { Operand: ColumnExpression }
-            || rightIsNull is SqlUnaryExpression { Operand: ColumnExpression })
+        if (leftNullable && rightNullable)
         {
             // (a == b && (a != null && b != null)) || (a == null && b == null)
             body = _sqlExpressionFactory.OrElse(