Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an active todo.txt file is deleted (or becomes unavailable), the tab is closed, but the file's contents still show on the screen #670

Closed
DeflateAwning opened this issue Feb 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@DeflateAwning
Copy link

DeflateAwning commented Feb 28, 2024

Bug Report

Important

App Version: v2.0.12-rc.1

Platform: Linux

Installation Method: deb

Steps to Reproduce:
0. Ensure that you have at least one normal tab open in sleek.

  1. Create an empty todo.txt file.
  2. Fill it with a todo item.
  3. Open that file with sleek, and have it active (i.e., that tab is active).
  4. Delete the file on disk.
  5. Observe that the tab is removed/deleted, but that the todo list still shows the previous todo items in that file from before it was deleted.

Expected behavior:
When the file is deleted, the tab should close (as it currently does), but the todo list should show the todo items in the file that becomes active.

Notes:
This doesn't seem like a big deal, but it comes up quite a bit with Syncthing because files become unwritable briefly sometimes.

In addition to fixing this bug, it'd be awesome if Sleek didn't require closing/reopening the file if it's resynced by Syncthing (but that's probably a bigger fix).

@DeflateAwning DeflateAwning added the bug Something isn't working label Feb 28, 2024
@github-project-automation github-project-automation bot moved this to Backlog in sleek 2.x Feb 28, 2024
@ransome1 ransome1 moved this from Backlog to Bugs in sleek 2.x Feb 29, 2024
@ransome1 ransome1 moved this from Bugs to In Progress in sleek 2.x Mar 16, 2024
ransome1 added a commit that referenced this issue Mar 16, 2024
…. Added file watcher settings (#675 & #676). Fixed #670. Continued work on #609.
@ransome1
Copy link
Owner

@DeflateAwning could you please check if this now works as expected in the latest pre-release?

@github-project-automation github-project-automation bot moved this from In Progress to Done in sleek 2.x Mar 23, 2024
@DeflateAwning
Copy link
Author

Haven't seen it break, but this one's a tough one to verify as it was only happening sometimes. Thanks for the fix; will update if I see it happen again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants