Added GcsLogStore implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medb
suggested changes
Nov 25, 2020
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
medb
suggested changes
Nov 25, 2020
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
medb
suggested changes
Nov 25, 2020
There was a problem hiding this comment.
Please mark resolved comments as resolved to simplify review process: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations
medb
suggested changes
Nov 30, 2020
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
medb
suggested changes
Dec 1, 2020
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
medb
suggested changes
Dec 1, 2020
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/apache/spark/sql/delta/storage/GcsLogStore.scala
Outdated
Show resolved
Hide resolved
medb
approved these changes
Dec 1, 2020
medb
reviewed
Dec 2, 2020
|
@ranu010101 / @medb - sorry for bothering you, but I was wondering if you could help on getting delta-io#468 merged... That's the connector for Oracle Object Store. |
|
@ddraj Unfortunately we are not able to help. We have the same issue and can not merge GCS support in Delta Lake because Delta Lake owners do not review their PRs: delta-io#560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.