Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum deployment targets. #78

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Increase minimum deployment targets. #78

merged 3 commits into from
Sep 13, 2022

Conversation

MaximAlien
Copy link
Contributor

@MaximAlien MaximAlien commented Sep 13, 2022

PR increases minimum deployment targets to:

  • iOS 12.0
  • tvOS 12.0
  • macOS 10.14
  • watchOS 5.0

Copy link
Collaborator

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, Xcode 14 has dropped support for the iOS 11 simulator, so now seems like a good time for this library to also stop promising support for it.

The .pbxproj is only used by Carthage. CocoaPods needs the following file to be updated:

s.ios.deployment_target = "10.0"
s.osx.deployment_target = "10.12"
s.watchos.deployment_target = "3.0"
s.tvos.deployment_target = "10.0"

(Package.swift doesn’t specify any minimum deployment target.)

The readme also needs to be updated:

- iOS 10.0+ / Mac OS X 10.12+ / tvOS 10.0+ / watchOS 3.0+ / Linux

Copy link
Collaborator

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@1ec5 1ec5 merged commit 050341c into raphaelmor:master Sep 13, 2022
@MaximAlien MaximAlien deleted the maxim/increase-minimum-deployment-target branch September 13, 2022 20:26
@MaximAlien MaximAlien mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants