Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scikit-learn>=1.1.2 #300

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Use scikit-learn>=1.1.2 #300

merged 5 commits into from
Dec 2, 2022

Conversation

raphaelvallat
Copy link
Owner

@raphaelvallat raphaelvallat self-assigned this Aug 29, 2022
@musicinmybrain
Copy link
Contributor

Works great as a downstream patch in Fedora Linux.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 98.58% // Head: 98.58% // No change to project coverage 👍

Coverage data is based on head (c198be8) compared to base (1f329ef).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          18       18           
  Lines        3320     3320           
  Branches      540      540           
=======================================
  Hits         3273     3273           
  Misses         25       25           
  Partials       22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelvallat raphaelvallat linked an issue Nov 25, 2022 that may be closed by this pull request
@raphaelvallat
Copy link
Owner Author

raphaelvallat commented Nov 25, 2022

Scikit-learn 1.1 and later requires Python 3.8 or newer (from sklearn documentation).

  • To merge this PR, need to disable unit testing for Python 3.7

Update: to avoid pip conflicts, I think it is simpler to just remove any strict requirements for sklearn.

@raphaelvallat raphaelvallat merged commit c97b0ef into master Dec 2, 2022
@raphaelvallat raphaelvallat deleted the update_sklearn branch December 2, 2022 23:15
@musicinmybrain musicinmybrain mentioned this pull request Dec 30, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogisticRegression fails when X is a single predictor
2 participants