Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix groupby.mean for only numeric values #363

Merged
merged 8 commits into from
Jun 4, 2023

Conversation

jajcayn
Copy link
Contributor

@jajcayn jajcayn commented Jun 1, 2023

There was a change in the default behaviour for groupby(...).mean(), now the default is numeric_only=False

@raphaelvallat raphaelvallat self-requested a review June 4, 2023 11:56
@raphaelvallat raphaelvallat linked an issue Jun 4, 2023 that may be closed by this pull request
@raphaelvallat raphaelvallat added the bug 💥 Something isn't working label Jun 4, 2023
@raphaelvallat
Copy link
Owner

Awesome thanks for catching this! A few comments:

  1. We need to bump the pandas dependency to 1.1, since numeric_only is not present in 1.0
  2. I think there are many other groupby().mean() in the Pingouin code. To be safe I think we need to edit all of them.
  3. Unit tests are failing for unrelated reasons. I'll fix later.

I'll work on 1 and 2 now. Thanks

@raphaelvallat raphaelvallat merged commit 7923141 into raphaelvallat:master Jun 4, 2023
@jajcayn jajcayn deleted the fix/mean_only_numeric branch February 13, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pairwise tests with mixed design fail with new pandas 2.0
2 participants