Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RBC sign in mwu #424

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix RBC sign in mwu #424

merged 1 commit into from
May 27, 2024

Conversation

raphaelvallat
Copy link
Owner

Relates to #417

  • Fixes the sign of the RBC effect size in pg.mwu
  • Improved documentation for RBC

References

@raphaelvallat raphaelvallat added the invalid 🚩 This doesn't seem right label May 25, 2024
@raphaelvallat raphaelvallat self-assigned this May 25, 2024
@raphaelvallat raphaelvallat mentioned this pull request May 25, 2024
Closed
viggotw
viggotw approved these changes May 26, 2024
View reviewed changes
Copy link

@viggotw viggotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes and documentation looks good. I have verified the effect size calculations using JASP on five randomly generated datasets, and they all checked out. Good job! 🔥

@viggotw viggotw mentioned this pull request May 26, 2024
Closed
@raphaelvallat raphaelvallat merged commit b563de7 into main May 27, 2024
2 checks passed
@raphaelvallat raphaelvallat deleted the fix_rbc_sign branch May 27, 2024 05:55
@mmpeng9 mmpeng9 mentioned this pull request Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viggotw viggotw viggotw approved these changes

Assignees

@raphaelvallat raphaelvallat

Labels
invalid 🚩 This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaelvallat @viggotw