Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string representation of yasa.Hypnogram #129

Merged
merged 4 commits into from
Dec 31, 2022

Conversation

raphaelvallat
Copy link
Owner

Closes #128

Let me know if the text looks good. Happy to make edits.

image

@raphaelvallat raphaelvallat added the enhancement 🚧 New feature or request label Dec 31, 2022
@raphaelvallat raphaelvallat self-assigned this Dec 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Base: 92.56% // Head: 92.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (61c642a) compared to base (37058f2).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head 61c642a differs from pull request most recent head 701f7f9. Consider uploading reports for the commit 701f7f9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files          23       23           
  Lines        3119     3121    +2     
=======================================
+ Hits         2887     2889    +2     
  Misses        232      232           
Impacted Files Coverage Δ
yasa/hypno.py 98.31% <50.00%> (-0.28%) ⬇️
yasa/detection.py 97.85% <0.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@remrama remrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 💃 with some thoughts to take or leave

yasa/hypno.py Outdated Show resolved Hide resolved
yasa/hypno.py Outdated Show resolved Hide resolved
@raphaelvallat raphaelvallat merged commit 9d9fb74 into master Dec 31, 2022
@raphaelvallat raphaelvallat deleted the change_str_representation branch December 31, 2022 17:36
@raphaelvallat raphaelvallat mentioned this pull request Jan 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚧 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change string representation of the yasa.Hypnogram class (__repr__)
3 participants