Skip to content

Commit

Permalink
Minor refactoring.
Browse files Browse the repository at this point in the history
  • Loading branch information
raphw committed Jan 3, 2023
1 parent 283c195 commit deae823
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,15 @@ protected AbstractByteBuddyTaskConfiguration(String name, SourceSet sourceSet) {
/**
* {@inheritDoc}
*/
public void execute(final Project project) {
@SuppressWarnings("unchecked") final S extension = (S) project.getExtensions().getByName(name);
public void execute(Project project) {
@SuppressWarnings("unchecked")
S extension = (S) project.getExtensions().getByName(name);
if (extension.getTransformations().isEmpty() && extension.getDiscovery() == Discovery.NONE) {
project.getLogger().debug("Not configuring task for source set '{}' as no transformations are defined and discovery is disabled", sourceSet.getName());
} else {
project.getLogger().debug("Configuring Byte Buddy task for source set '{}' as '{}'", sourceSet.getName(), name);
final AbstractCompile compileTask = (AbstractCompile) project.getTasks().getByName(sourceSet.getCompileJavaTaskName());
final T byteBuddyTask = project.getTasks().create(name, extension.toType());
AbstractCompile compileTask = (AbstractCompile) project.getTasks().getByName(sourceSet.getCompileJavaTaskName());
T byteBuddyTask = project.getTasks().create(name, extension.toType());
byteBuddyTask.setGroup("Byte Buddy");
byteBuddyTask.setDescription("Transforms the classes compiled by " + compileTask.getName());
byteBuddyTask.dependsOn(compileTask);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,8 @@ public class ByteBuddyPlugin implements Plugin<Project> {
/**
* {@inheritDoc}
*/
public void apply(final Project project) {
Object androidExtension = project.getExtensions().findByName("android");
if (androidExtension != null) {
public void apply(Project project) {
if (project.getExtensions().findByName("android") != null) {
project.getLogger().debug("Applying Byte Buddy Android plugin");
try {
@SuppressWarnings("unchecked")
Expand Down Expand Up @@ -106,7 +105,6 @@ public void execute(JavaPlugin plugin) {
String name = sourceSet.getName().equals(SourceSet.MAIN_SOURCE_SET_NAME)
? "byteBuddy"
: (sourceSet.getName() + "ByteBuddy");

AbstractByteBuddyTaskExtension<?> extension = ObjectFactory.newInstance(project,
DISPATCHER.getExtensionType(),
project);
Expand Down

0 comments on commit deae823

Please sign in to comment.