Skip to content

Commit

Permalink
Remove bad comment refactoring and add description for use of interna…
Browse files Browse the repository at this point in the history
…l name on elements that do not define an internal name according to the documentation.
  • Loading branch information
raphw committed Jul 22, 2021
1 parent da712db commit f82339e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public interface NamedElement {
String EMPTY_NAME = "";

/**
* Returns the name of this element as it is found in the source code. If no such name exists,
* Returns the display name of this element as it is found in the source code. If no such name exists,
* an empty string is returned.
*
* @return The name of this element as given in a Java program's source code.
Expand All @@ -44,16 +44,18 @@ public interface NamedElement {
interface WithRuntimeName extends NamedElement {

/**
* Returns the internalName of this byte code element.
* Returns the binary name of this byte code element. If no well-defined internal name is known for this element,
* the actual name is returned.
*
* @return The internalName of this byte code element as visible from within a running Java application.
* @return The binary ame of this byte code element as visible from within a running Java application.
*/
String getName();

/**
* Returns the internal internalName of this byte code element.
* Returns the internal name of this byte code element. If no well-defined internal name is known for this element,
* the actual name is returned.
*
* @return The internal internalName of this byte code element as used within the Java class file format.
* @return The internal name of this byte code element as used within the Java class file format.
*/
String getInternalName();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,9 @@ public interface TypeDescription extends TypeDefinition, ByteCodeElement, TypeVa
int getActualModifiers(boolean superFlag);

/**
* Returns the simple internalName of this type.
* Returns the simple name of this type.
*
* @return The simple internalName of this type.
* @return The simple name of this type.
*/
String getSimpleName();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* Implementation of an
* {@link net.bytebuddy.implementation.bind.MethodDelegationBinder.AmbiguityResolver}
* that resolves conflicting bindings by considering equality of a target method's internalName as an indicator for a dominant
* that resolves conflicting bindings by considering equality of a target method's name as an indicator for a dominant
* binding.
* <p>&nbsp;</p>
* For example, if method {@code source.foo} can be bound to methods {@code targetA.foo} and {@code targetB.bar},
Expand Down

0 comments on commit f82339e

Please sign in to comment.