Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add confirmation when deleting profile #206

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

sspaeth-r7
Copy link
Contributor

@sspaeth-r7 sspaeth-r7 commented Oct 17, 2022

This PR adds a confirmation dialog when deleting a login entry. This is in response to issue #204 by @ceastman-r7 requesting this feature be added.

The changes have been tested on macOS and Windows.

@sspaeth-r7 sspaeth-r7 marked this pull request as ready for review October 18, 2022 20:31
Copy link

@ceastman-r7 ceastman-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@cdoughty-r7 cdoughty-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sspaeth-r7 sspaeth-r7 merged commit 220bba8 into rapid7:master Oct 19, 2022
sspaeth-r7 added a commit to sspaeth-r7/awsaml that referenced this pull request Oct 25, 2022
Merge pull request rapid7#206 from sspaeth-r7/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants