Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic logging #236

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

mmurrell-r7
Copy link
Contributor

@mmurrell-r7 mmurrell-r7 commented Oct 4, 2023

This PR implements some basic logging in the Main process.

By default, logs are written to the following locations:

on Linux: ~/.config/Awsaml/logs/main.log
on macOS: ~/Library/Logs/Awsaml/main.log
on Windows: %USERPROFILE%\AppData\Roaming\Awsaml\logs\main.log

Copy link
Contributor

@dgreene-r7 dgreene-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny nits. Also just wanted to make sure that there aren't any events that we're not covering. Do we know what electron's BrowserWindow startup process looks like in terms of event dispatch?

src/main/index.js Outdated Show resolved Hide resolved
src/main/index.js Outdated Show resolved Hide resolved
@mmurrell-r7 mmurrell-r7 merged commit 8e67fa5 into rapid7:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants