-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLGN-380 Salesforce - add de-duping #1993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaverty-r7
reviewed
Sep 26, 2023
plugins/salesforce/komand_salesforce/tasks/monitor_users/task.py
Outdated
Show resolved
Hide resolved
plugins/salesforce/komand_salesforce/tasks/monitor_users/task.py
Outdated
Show resolved
Hide resolved
plugins/salesforce/komand_salesforce/tasks/monitor_users/task.py
Outdated
Show resolved
Hide resolved
llaszuk-r7
force-pushed
the
plgn-380_salesforce_error_de-duping
branch
from
September 27, 2023 07:39
fc2b2f3
to
3436f49
Compare
dlaverty-r7
approved these changes
Sep 27, 2023
igorski-r7
approved these changes
Sep 27, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Sep 27, 2023
joneill-r7
pushed a commit
that referenced
this pull request
Sep 28, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Sep 28, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Sep 29, 2023
joneill-r7
pushed a commit
that referenced
this pull request
Sep 29, 2023
llaszuk-r7
added a commit
that referenced
this pull request
Oct 2, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Oct 2, 2023
llaszuk-r7
added a commit
that referenced
this pull request
Oct 2, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Oct 2, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Oct 3, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Oct 5, 2023
joneill-r7
pushed a commit
that referenced
this pull request
Oct 9, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Oct 10, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Oct 11, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Oct 12, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Oct 12, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Oct 13, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Oct 16, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Oct 16, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Oct 17, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Oct 23, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 1, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 1, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 2, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 6, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 7, 2023
joneill-r7
pushed a commit
that referenced
this pull request
Nov 7, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 9, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 10, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 14, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 15, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 16, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
jerichardson-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
dlaverty-r7
added a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
jerichardson-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
* [PLGN-133] Samanage/Solarwinds updates (#1623) * Updated docker file to include curl for adding attachment * Updated examples for help.md to include strings for ids * Updated output ids to strings for consistency * Updated attach incident example * Removed print statement * Updated formatting with black check --------- * [PLGN-133] Solarwinds - updated id outputs as integers to line up with expected inputs (#1624) * Updated to output ids as integers to line up with expected inputs * Updated example fields * Updated example fields --------- * [PLGN-46] - Cybereason - Archive Sensor Functionality (#1566) * added get_sensor action * fixed checksum * sensor stats added acc * finished spec file, regenerated * generated archive sensor action * added example output for archive sensor * refactoring for lint * updated descriptions in spec file for validator * created and tested 2 new actions, need to add unit tests * update spec file * refactored quarantine action, added unit tests for most of the actions * added unit tests 95 percent coverage * fix for plugin validator * fix lint * prospector fix * unit test fix * dympna change * igor updates * lukasz changes * formatting help.md to use 2 spaces instead of 4 * updated version history note * Cybereason output fix (#1727) * updated output * updated output for cybereaosn * regen * version bump * specific fake email * fixed schema issue * changing back to rapid7 vendor * version bump in helpmd * [MC-1452] Update Okta plugin (#1733) * [MC-1452] Update Okta plugin * [MC-1452] Fixed test * [MC-1452] Fix prospector * [MC-1452] Update help.md * [MC-1452] Update SDK image to latest version * [MC-1452] Update unit tests for task --------- * IC fixes (#1792) * [MC-1452] Return status code in Monitor Logs task in Okta plugin (#1764) * [MC-1452] Return status code in Monitor Logs task * [MC-1452] Update exceptions in api.py * [MC-1452] Fix prospector * [MC-1452] Use logger instance * Change port input back to string (#1809) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin (#1838) * [MC-1452] Update pagination in Monitor Logs task in Okta plugin * [MC-1452] Update unit tests * Updated armorblox plugin with the review comments. (#1721) * Initial commit for armorblox plugin * Fix validate errors * Timestamp changes * Updated armorblox-sdk 0.1.4 version in requirements.txt * Updated the suggestions for plugin.spec.yaml * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Update plugins/armorblox/help.md * Updated review comments * Update plugins/armorblox/icon_armorblox/triggers/get_incidents/schema.py * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Update plugins/armorblox/unit_test/payloads/get_remediation_action.json * Updated armorblox plugin with the required fixes * Updated plugin with latest fixes * Updated plugin with parameterized on test cases * "Fixed review comments" * Updated support field to community in plugin.spec.yaml --------- * [SOAR-14571] - Zoom - Delete User Returns Json Parsing Error (#1846) * updated status codes + black formatting * regen * added examples to plugin spec * Refresh * removed quotes from variables in spec * tidying up * changed imports to work with github validators * changed task unitest imports to work with github validators * fixed unit tests * Added example outputs to help.md * spec & help changes + status codes fix * checksum * period validation * revert description change * remove full stop in trigger schema * run black linter, fix unit tests and validators (#1857) * Zoom Validator Fixes (#1870) * [PLGN-361] Cloud Enable & Remove Defective Endpoint Actions from ICS Plugin (#1958) * plgn-380 salesforce add deduping (#1993) * plgn-412 remove clean data and stop converting output (#2002) * [PLGN-560] Update Proofpoint TAP task handling (#2069) * Updated task cutofftime, removed cleaning of logs, added debug * Updated task cutofftime, removed cleaning of logs, added debug * Removed page index from state if resetting collection time to max lookback * Updated unit tests following task updates --------- * [PLGN-560] Update proofpoint task subsequent run (#2077) * Updated task handling of query interval out of range * Updated unit test following task function update --------- * Moved plugin status to obsolete --------- Co-authored-by: Dympna Laverty <dympna_laverty@rapid7.com> Co-authored-by: TKuzas-R7 <107193006+TKuzas-R7@users.noreply.github.com> Co-authored-by: dsliwinski-r7 <73613193+dsliwinski-r7@users.noreply.github.com> Co-authored-by: Cyprian Dankowski <cyprian_dankowski@rapid7.com> Co-authored-by: Conor <93926445+cmcnally-r7@users.noreply.github.com> Co-authored-by: SamhithaTatipalli <57620888+SamhithaTatipalli@users.noreply.github.com> Co-authored-by: Ankita Sharma <ankita.sharma@xoriant.com> Co-authored-by: Rajat Upadhyaya <45485+urajat@users.noreply.github.com> Co-authored-by: llaszuk-r7 <99184394+llaszuk-r7@users.noreply.github.com> Co-authored-by: Mike Rinehart <32079048+mrinehart-r7@users.noreply.github.com>
jerichardson-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
cmcnally-r7
pushed a commit
that referenced
this pull request
Nov 21, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 22, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 22, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Nov 23, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Nov 23, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Nov 27, 2023
dlaverty-r7
pushed a commit
that referenced
this pull request
Nov 27, 2023
igorski-r7
pushed a commit
that referenced
this pull request
Nov 27, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 27, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 28, 2023
ablakley-r7
pushed a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR