[SOAR-18258] Whois - Update address action #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Validator is expected to fail, due to the apt-get install whois git in the Dockerfile (is required) |
rmurray-r7
requested review from
igorski-r7,
nmccullagh-r7,
dlaverty-r7,
joneill-r7,
ekelly-r7,
rbowden-r7 and
cmcnally-r7
rbowden-r7
approved these changes
Nov 21, 2024
igorski-r7
approved these changes
Nov 21, 2024
rmurray-r7
added a commit
that referenced
this pull request
Nov 22, 2024
* Update address action. SDK 6.2.0. v3.1.6 * black
rmurray-r7
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
A customer was experiencing an issue when proving an RIPE IP, the
orgnamewould not return when using ICON, but it would return when using WhoIs website. This is cause the orgname pointed to the description.As the description did not have an existing field, as the orgname pointed to it, I added a description field too.
SI TICKET
Describe the proposed changes:
descriptionoutput field. Correct mapping fororgnamefield)PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
When using the same IP the user used, it now returns the
orgname:As the above IP does not have a description, when using another RIPE IP, it returns the description too:
When specifiying the registrar as RIPE, the mapping also works:
