-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update wordpress plugins and themes lists #17253
Conversation
@h00die Question but how long did this take for you to run? For me this is taking literally 10's of minutes and I've not even gotten past |
It's not fast since there are sooooo many, however I set threads to 10, then ran some metal to the scrapper, yard waste to the dump, truck broke down and got it pushed to safety, had someone come try to jump it, nearly started a fire (alternator blew and must have a short), then came back home and it was done. When did it finish? No idea, but yea jack the threads up! |
Yeah unforunately I can't test this @h00die its taking 8-10 seconds to retrieve 10 themes. Upping the threads doesn't help since we only support threads running across hosts and have a limit of one thread per host scanned atm. I think overall the PR itself looks good though, just worried that without an upgrade to the tools that use it this will mean that there is simply too much data to go through in any reasonable timeframe. For me it would take about 66 hours at the current rate for this data to be processed just for the themes itself. Perhaps we should look at adding threading support to the scanner tools that use these lists? I'm just worried that since these are defaults users will start complaining that the defaults are too large. |
I'll give mine a run again and let you know what my timing is (26.22 minutes). This is also why the |
Looks good to me; Running against wordpress in docker with the msfconsole
In the future this could be done in parallel/made faster, but I don't think that's a blocker for this PR |
Thanks for checking @AlanFoster. Seeing how this might just be something on my end I'll go ahead and land this. If we have future complaints we can look into this further. |
Release NotesThe list of Wordpress plugins and themes has been updated to allow Metasploit tools to scan for a wider range of known themes and plugins on Wordpress targets. |
This PR runs
tools/dev/check_external_scripts.rb
to pull in the new wordpress plugins/themes.Verification
msfconsole
use auxiliary/scanner/http/wordpress_scanner
set exploitable false
set rhosts/threads
run
Example run w/ updates: