Updates failing MSSQL docker health check #19507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Continuation of #19484 and #19408
This PR re-adds the MSSQL acceptance tests. These were removed due to failing due to the health check being outdated after
SQL Server 2022 CU 14
. See https://hub.docker.com/r/microsoft/mssql-server.I believe the
-C
flag is now also required to get things working. From what I read I believe this is due to the container now defaulting to encryption being required, which means you need to pass-C
with thesqlcmd
to tell it to trust the server cert. At least this is what is being discussed.Verification