Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates failing MSSQL docker health check #19507

Merged

Conversation

cgranleese-r7
Copy link
Contributor

@cgranleese-r7 cgranleese-r7 commented Sep 27, 2024

Note

Continuation of #19484 and #19408

This PR re-adds the MSSQL acceptance tests. These were removed due to failing due to the health check being outdated after SQL Server 2022 CU 14 . See https://hub.docker.com/r/microsoft/mssql-server.

Note Starting with SQL Server 2022 CU 14, we are updating SQL Server 2022 container images to include the new mssql-tools18 package. With the introduction of SQL Server 2022 CU 14, and in all future container images, the previous directory /opt/mssql-tools/bin will be phased out. The new directory for Microsoft ODBC 18 tools will be '/opt/mssql-tools18/bin', aligning with the latest tools offering.

I believe the -C flag is now also required to get things working. From what I read I believe this is due to the container now defaulting to encryption being required, which means you need to pass -C with the sqlcmd to tell it to trust the server cert. At least this is what is being discussed.

Verification

  • CI goes green

@cgranleese-r7 cgranleese-r7 added the rn-fix release notes fix label Sep 27, 2024
@adfoster-r7 adfoster-r7 merged commit 48c358f into rapid7:master Sep 27, 2024
82 checks passed
@adfoster-r7 adfoster-r7 added rn-no-release-notes no release notes and removed rn-fix release notes fix labels Sep 27, 2024
@cgranleese-r7 cgranleese-r7 deleted the update-failing-mssql-health-check branch September 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-no-release-notes no release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants