Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid instantiating the module during recalculate #4917

Merged
merged 1 commit into from
Mar 13, 2015

Conversation

hdm
Copy link
Contributor

@hdm hdm commented Mar 12, 2015

This provides a speed improvement during the payload set recalculation, which also improves start time. This should have been part of #4894, but was overlooked. This shaves another ~500ms off startup.

Startup time from the master branch:

$ git checkout master

$ for i in `seq 1 3`; do time ./msfconsole  -q -x 'exit'; done

real    0m5.089s
user    0m4.590s
sys 0m0.393s

real    0m5.141s
user    0m4.458s
sys 0m0.586s

real    0m5.172s
user    0m4.559s
sys 0m0.521s

Startup time from the PR branch:

$ git checkout bug/use-cached-size-during-recalculate
$ for i in `seq 1 3`; do time ./msfconsole  -q -x 'exit'; done

real    0m4.591s
user    0m4.043s
sys 0m0.465s

real    0m4.783s
user    0m4.169s
sys 0m0.498s

real    0m4.535s
user    0m4.005s
sys 0m0.424s

@bcook-r7 bcook-r7 self-assigned this Mar 12, 2015
@bcook-r7 bcook-r7 merged commit 376d05f into rapid7:master Mar 13, 2015
@bcook-r7
Copy link
Contributor

Darn, I should have caught that in the first review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants