This repository has been archived by the owner on Jan 22, 2024. It is now read-only.
Post vs2013 39 42 43 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking version info now has support for the later versions of windows based on the documentation available from MSDN.
Pulled the latest version of the incognito code from: http://labs.mwrinfosecurity.com/blog/2012/07/18/incognito-v2-0-released/ This included a fix for Windows 2003 x64, which was reported as a bug in RM 8281.
This allows for system proxy setting to be pulled out. Windows-only at this point.
|
Test PASSED. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is much like #46, in that it includes the following PRs from @OJ:
It avoids the following:
Command refactor for clean shutdown + inline calls #34 depends on @jlee-r7 eyeballs.
Fix for webcam_snap crashing #44 depends on Refactor of channels to better manage lifetimes and clean up nicely #38, which also depends on Command refactor for clean shutdown + inline calls #34.
So right now, #34 is a pretty major blocker, but does not hold up #39, #42, and #43.
These PRs are all already demoed and tested; the purpose of this PR-of-PRs is just to avoid needless extra builds and testing. I'm landing it pretty much immediately.