CPE: use safe_load, update CPEs #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsellers-r7
commented
Oct 27, 2020
| @@ -32,7 +33,8 @@ | |||
| <example chromecast.generation="11" chromecast.capabilities="Video Assist">CN=Chromecast ICA 11 (Video Assist),OU=Cast,O=Google Inc,L=Mountain View,ST=California,C=US</example> | |||
| <example chromecast.generation="12">CN=Chromecast ICA 12,OU=Cast,O=Google Inc,L=Mountain View,ST=California,C=US</example> | |||
| <param pos="0" name="os.vendor" value="Google"/> | |||
| <param pos="0" name="os.product" value="ChromeOS"/> | |||
| <param pos="0" name="os.product" value="Chrome OS"/> | |||
There was a problem hiding this comment.
Note: this change aligns the name with the Google usage of the term (space vs no space) and allows the NIST CPE mapping to automatically match. If this causes issues I can handle it with a remapping instead.
CC @hdm
Merged
rkirk-r7
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
update_cpes.pyso that it usesyaml.safe_load()instead ofyaml.load(). This should reduce the risk when loading YAML. I've also run it against our fingerprint databases using the latest data from NIST.I've also added a
.snykfile in order to suppress the Synk warning on PyYAML. We don't currently use a vulnerable code path, Snyk doesn't check to see if you are using the vulnerable code path, and there is no full library level fix for this other than to usesafe_load()(which this PR does) or theSafeLoaderloader.https://app.snyk.io/vuln/SNYK-PYTHON-PYYAML-590151
Motivation and Context
Risk reduction
How Has This Been Tested?
rspec, Github PR hooksTypes of changes
Checklist: