Fix/is name underscores #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Mar 25, 2024
| @@ -342,6 +342,13 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'with a name containing underscores' do | |||
There was a problem hiding this comment.
Not a blocker; would it make sense to rename is_name? is is_dns_name? or something similar? I intentionally didn't call it on the initial PR as I thought the distinction wasn't super important, but now I wish I had as hostname vs DNS name have very different rules apparently 😄
dwelch-r7
reviewed
Mar 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 2181, DNS names can contain underscores. Since the
.is_name?class method is intended to inspect the value and tell if it's value for resolution, it should allow underscores in the labels.Included a test to show that the legitimate case of
_ldap._tcp.msflab.localnow works as intended.