-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few more sub-country pseudo codes #26
Comments
Hmm I see where this lack of granularity could be annoying. I'm wary of starting to add political sub-territories just because they exist (#19). But I do think adding a few regions like these that are commonly considered culturally or geographically distinct would be pretty helpful without adding much overhead. Overseas territories in particular should have their own identities. |
Cool - yeah I think anything that has its own Wikidata QID it's at least notable enough for inclusion, even if it doesn't have a ISO country code. Also I agree - I'm not quite suggesting going down the the state/province level, unless we made a separate larger distribution for that. |
… and Dhekelia base areas from GB (re: #26)
Rename Ireland country feature Republic of Ireland
Correct Wikidata QID of SH Add Saint Helena as a subterritory of SH (re: #26)
Rename CN feature from China to People's Republic of China Correctly make RC an alias of TW, not CN
…lands of Alderney and Guernsey in addition to Sark (re: #26)
…go along with Diego Garcia (re: #26)
Rename French Southern and Antarctic Lands to French Southern Territories
Add features for outermost regions and overseas countries and territories of the EU (re: #26) Make isIn and isInEuropeanUnion return null if the query or bounds cannot be coded
I added 100 new features in v4.0.0, I think we can close this. People should feel free to open new issues if they need more! |
This is not a high priority issue, but maybe a nice-to-have.
CountryCoder and LocationConflation are integrated into Name Suggestion Index now which is pretty cool..
Check out the entries on https://nsi.guide to see what I mean:
A thing I am running into is:
Some countries like US, GB, FR include a bunch of sub territories. Technically the US includes Marshall Islands and GB includes Bermuda. FR is nice because we can use the code FX to mean "Metropolitan France". But for some situations, it would be really nice to have dedicated code strings for:
I'm not familiar with what all countries contain territories, and not sure to what extent Country Coder already includes some of these.. just brainstorming that it would be nice to say 'conus' or 'scotland' to return just those parts.
The text was updated successfully, but these errors were encountered: