Changed buttons #12
Changed buttons #12
Conversation
…de-components into feature/v3-colors-and-tweaks
…de-components into feature/v3-colors-and-tweaks
| @@ -180,7 +180,7 @@ function color(variable, fallback) { | |||
|
|
|||
| <h2 class="font-bold text-lg">Button components</h2> | |||
| <div class="grid grid-cols-5 gap-5"> | |||
| <x-rapidez::button>Button</x-rapidez::button> | |||
There was a problem hiding this comment.
The button.blade is used for base classes on all buttons. If you want a variant we recommend use the button you want to use, like button.outline, or button.conversion. This button doesnt have a background since it isn't a variant.
There was a problem hiding this comment.
A variant with the default background would be nice to keep? For example pagination; we don't need a coloured variant there; but outline could be an option but the default button feels better.
There was a problem hiding this comment.
Agree, probably we are not going to use the default button but it would be nice to have a background on it. I think for the pagination we still use primary or secondary.
…ture/v3-colors-and-tweaks
…de-components into feature/v3-colors-and-tweaks
There was a problem hiding this comment.
This is already handled within #13 right?
…ure/v3-colors-and-tweaks
…de-components into feature/v3-colors-and-tweaks
jordythevulder
dismissed stale reviews from JimmyHoenderdaal and Roene-JustBetter
via
4caf8db
…de-components into feature/v3-colors-and-tweaks
|
I updated the screenshots. Within this PR and within the Readme |
README.md
Outdated
| emphasis: color('--border-emphasis', colors.slate[400]), | ||
| DEFAULT: color('--border', colors.slate[300]), |
There was a problem hiding this comment.
This should go in a separated PR, related: rapidez/core#699
README.md
Outdated
| @@ -34,6 +34,8 @@ The base button doesn't have any styling; here, we only use the `x-rapidez::tag` | |||
| - [Outline](https://github.com/rapidez/blade-components/blob/master/resources/views/components/button/outline.blade.php) | |||
| - [Conversion](https://github.com/rapidez/blade-components/blob/master/resources/views/components/button/conversion.blade.php) | |||
| - [Slider](https://github.com/rapidez/blade-components/blob/master/resources/views/components/button/slider.blade.php) | |||
| - [Muted](https://github.com/rapidez/blade-components/blob/master/resources/views/components/button/muted.blade.php) | |||
There was a problem hiding this comment.
This one doesn't and should not exist.
This prevents the outline button from also having a border-b.
Also changed general button styling. and added default variant: