Frontend colors suggestion change #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| 'id' => $name ?? null, | |||
| 'name' => $name ?? null, | |||
| 'dusk' => $attributes->get('v-bind:dusk') ? null : $name ?? null, | |||
| 'class' => 'w-full py-2 pl-3 pr-8 border-gray-200 rounded focus:ring-neutral focus:border-neutral sm:text-sm' | |||
| 'class' => 'w-full py-2 pl-3 pr-8 border border-neutral-110 rounded outline-0 ring-0 focus:ring-transparent focus:border-neutral sm:text-sm' | |||
There was a problem hiding this comment.
border-neutral-110 shouldn't be necessary since it's set by default on the "border" class
There was a problem hiding this comment.
It is necessary to set de border color here, we are using tailwindForms. This plugin sets a default border color on input components, so we need to add the border-neutral-110 here.
JimmyHoenderdaal
previously approved these changes
Nov 19, 2024
jordythevulder
approved these changes
Nov 19, 2024
JimmyHoenderdaal
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed colors
Added colors
The enhanced color will most likely be used for conversions, such as "Add to Cart" buttons.
Updated tailwind.config with colors:
If we are going to use the colors above we should also change it in here:
https://github.com/rapidez/reviews & https://github.com/rapidez/account
Note
Buttons & inputs will be replaced with the buttons from the blade-components. There is a draft here: #632