Frontend - Styling autocomplete #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve max-md for overflow-clip
…re into feature/frontend-autocomplete
Roene-JustBetter
requested review from
jordythevulder,
Jade-GG and
JimmyHoenderdaal
Roene-JustBetter
commented
Dec 5, 2024
| v-on:value-selected="search" | ||
| component-id="autocomplete" | ||
| :inner-class="{ input: '{{ $inputClasses }}' }" | ||
| {{-- These classes are only used when you come from a page with a product listing, --}} | ||
| {{-- click on a link that leads to a 404 page and try to use the search there --}} | ||
| class="relative [&_*]:!m-0 [&_[isclearicon=]]:!mr-2 [&_.cancel-icon]:!fill-[#595959] [&_[groupposition=right]]:!absolute [&_[groupposition=right]]:!top-2/4 [&_[groupposition=right]]:!right-0 [&_[groupposition=right]]:!-translate-y-2/4" |
There was a problem hiding this comment.
I have tested the case local:
- Created a link that leads to a 404 page.
- Navigated to a page where a product listing is used.
- Clicked on the link that leads to a 404 page.
- Used the autocomplete to search.
Tested runningyarn dev&yarn prod
Closed
royduin
requested changes
Dec 5, 2024
resources/views/layouts/partials/header/autocomplete/no-results.blade.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Roy Duineveld <royduineveld@gmail.com>
Co-authored-by: Roy Duineveld <royduineveld@gmail.com>
…s.blade.php Co-authored-by: Roy Duineveld <royduineveld@gmail.com>
Jade-GG
reviewed
Dec 10, 2024
resources/views/layouts/partials/header/autocomplete/categories.blade.php
Outdated
Show resolved
Hide resolved
|
I still like to see a review from @jordythevulder and/or @JimmyHoenderdaal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed:
Screenshots current autocomplete
Screenshots new autocomplete
Added no results that doesn't exist in the old autocomplete
