Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] Improve frontend 2 #682

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[3] Improve frontend 2 #682

wants to merge 3 commits into from

Conversation

JimmyHoenderdaal
Copy link
Member

This PR is ongoing and contains a couple of visual improvements to the rapidez core
stuff like responsive views/color changes and such

@JimmyHoenderdaal JimmyHoenderdaal changed the title Improve frontend 2 [3] Improve frontend 2 Dec 20, 2024
jordythevulder
jordythevulder previously approved these changes Dec 20, 2024
View reviewed changes
@royduin
Copy link
Member

royduin commented Dec 20, 2024

A bit more info would be nice; why? What's visually changed? Maybe a before/after screenshot.

@Roene-JustBetter
Copy link
Member

Roene-JustBetter commented Dec 23, 2024 •
edited
Loading

A bit more info would be nice; why? What's visually changed? Maybe a before/after screenshot.

I have added some extra tweaks:

  • Change breakpoint for PDP from md to lg
  • When you have products in your cart the button in the header have an active state. I changed the v-cloaks so it won't jump anymore.
Scherm­afbeelding 2024-12-23 om 16 08 27
  • Fix slider on category the slider didn't showed. I also fixed the icons (they didn't showed because of icon deferring). Also fixed the dots and correctly position the prev/next buttons.
Scherm­afbeelding 2024-12-23 om 16 09 28
  • Also fixed group products layout when the add to cart doesn't fit next to the quantity select.
Scherm­afbeelding 2024-12-23 om 16 13 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roene-JustBetter Roene-JustBetter Roene-JustBetter approved these changes

@jordythevulder jordythevulder jordythevulder left review comments

@royduin royduin Awaiting requested review from royduin royduin is a code owner

@indykoning indykoning Awaiting requested review from indykoning indykoning is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JimmyHoenderdaal @royduin @Roene-JustBetter @jordythevulder