[3.x] Fix issues with add-to-cart on listing when product has super_attributes #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Jan 14, 2025
| return this.simpleProduct?.thumbnail || this.simpleProduct?.images?.[0] || this.product?.thumbnail | ||
| }, | ||
|
|
||
| shouldRedirectToProduct: function () { |
There was a problem hiding this comment.
Previously we also listened to config.show_swatches should we check this here?
There was a problem hiding this comment.
In principle it shouldn't really matter for this check. If you have a product that doesn't have all options filled, it doesn't matter whether the options are shown or not.
royduin
reviewed
Jan 15, 2025
|
Conflict 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the context of the product listing:
The add to cart button would always redirect to the product page even if you have options selected, making the options shown in the listing completely useless. With this PR, it will actually add the product to your cart if you have selected an option for each of the super_attributes.
Selecting an option that should change the product image didn't actually change the product image, even though those images were all getting indexed into ES. This PR makes the product image listen to the selected options appropriately.
The add to cart button was always hidden if you didn't elect to show swatches in the product listing, whereas that option is completely unrelated to whether or not the button should be shown. With the previous point I've had to move a few things around, along with which I've changed this behavior to be more in line with what you would expect.