-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix layout shift on thumbnails & quantity #710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apidez/core into feature/layoutshift-thumbnails
Jade-GG
requested review from
jordythevulder,
Roene-JustBetter and
JimmyHoenderdaal
January 22, 2025 13:58
royduin
reviewed
Jan 23, 2025
resources/views/product/partials/gallery/thumbnails/showMore.blade.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Roy Duineveld <royduineveld@gmail.com>
JimmyHoenderdaal
previously approved these changes
Jan 27, 2025
Roene-JustBetter
previously approved these changes
Jan 27, 2025
indykoning
reviewed
Jan 27, 2025
Jade-GG
dismissed stale reviews from Roene-JustBetter and JimmyHoenderdaal
via
January 29, 2025 13:42
513abef
👍 I've made the thumbnails no longer show if there's only one image to show (including making sure that fix doesn't cause any new layout shifts in either case), which concludes fixing every edge case I could personally find. |
royduin
requested changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #675 without any duplication. I took the untested code I posted there, tested and fixed it, and made some adjustments to make the code slightly nicer.
Some notes on this:
resizedPath
helper here currently, as the URL constructor doesn't like paths that are not full URLs. This means we cannot pass something like/catalog/product/m/p/mp07-blue_main_1.jpg.webp
(which is what we have here) into the function, it will throw an error. Should we change/fix this?@unless
to make thev-cloak
+v-if
combination as clear as I could, making sure both checks have the same conditional. At the end of the day, we're making a small code quality sacrifice here to allow us to fully eliminate any content jumps.+3
overlay by only adding it on actual breakpoint positions (this is thein_array($imageId + 1, $breakpoints)
check). This does, however, complicate the code further. I figured it's worth moving the overlay to a separate partial, but I would love to hear opinions on this.