Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instantsearch] Swatch filter #718

Merged
merged 17 commits into from
Jan 31, 2025
Merged

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Jan 29, 2025

I've kept the useSwatches stuff here as there isn't really any other way to do this cleanly.

We ran into this before elsewhere recently and looked more deeply into what options we have and there really isn't much. Basically two options:

  • We keep it as is, getting the swatch data with an API call and using it here. This is clean, but it requires extra functionality for something that seems like it should be quite simple.
  • We could add the swatch data into the label itself and then filter it out on the frontend, which would allow us to keep all the data within ES. This would work, but it's not very clean and quite hacky.

@royduin royduin merged commit d9f2499 into instantsearch Jan 31, 2025
7 of 12 checks passed
@royduin royduin deleted the feature/instantsearch-swatches branch January 31, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants