Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect join #24

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Removed incorrect join #24

merged 1 commit into from
Feb 22, 2024

Conversation

royduin
Copy link
Member

@royduin royduin commented Jan 4, 2024

Not sure where this is used but it's incorrect and doesn't do anything here. Maybe reviews are needed somewhere else but not sure how that would work because review_entity_summary.primary_id is just the primary key, it's not linked to review.review_id. It's a summary, so it's not linked to an individual review.

This was added with: #13

@royduin
Copy link
Member Author

royduin commented Jan 24, 2024

@jbclaudio

@royduin royduin merged commit 0b710a3 into master Feb 22, 2024
2 checks passed
@royduin royduin deleted the cleanup branch February 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants