Junebug channel for RapidPro. #435
Conversation
| .claim-description | ||
| %div | ||
| -blocktrans | ||
| Connect your <a href="http://junebug.praekelt.org/" target="_blank">Junebug</a> instance that you have |
There was a problem hiding this comment.
Should we not be prompting https here just for good measure?
|
Changes Unknown when pulling 2ebf46f on praekeltfoundation:feature/junebug-channel into ** on rapidpro:master**. |
temba/channels/handlers.py
Outdated
| external_id=data['message_id']) | ||
| return HttpResponse('OK') | ||
|
|
||
| else: # pragma: needs cover |
There was a problem hiding this comment.
- 'needs cover' is for existing code that we haven't yet written tests for so that we can keep coverage at '100%' - makes it easier to see where coverage has changed on a PR.
- 'no cover' is for stuff those few odd things we're ok with not testing
There was a problem hiding this comment.
Thanks, I'll remove these and attend to the coverage. I suspect this is due to me following the Jasmin example.
There was a problem hiding this comment.
I've fixed these with the last commit, this last one I've removed entirely as invalid actions are currently guarded against by the urlconf pattern for the handler.
| @@ -15,6 +15,7 @@ install: | |||
| - pip install --upgrade pip | |||
| - pip --version | |||
| - pip install -r pip-freeze.txt --upgrade | |||
| - pip install setuptools==33.1.1 # Recent version breaks packaging.requirements, this is a temp fix: https://github.com/pypa/setuptools/issues/942 | |||
There was a problem hiding this comment.
Have you seen this fail on Travis? pypa/setuptools#942 (comment) Seems to suggest we should be ok with latest pip here.
There was a problem hiding this comment.
it was failing last week when I wrote this, I'll remove it again as hopefully it's been fixed now. Thanks for spotting.
There was a problem hiding this comment.
Still failing on Travis, I've put this back for now.
|
Changes Unknown when pulling 95d0764 on praekeltfoundation:feature/junebug-channel into ** on rapidpro:master**. |
This reverts commit 9d6e4b2.
|
Changes Unknown when pulling b16081c on praekeltfoundation:feature/junebug-channel into ** on rapidpro:master**. |
|
@rowanseymour thanks for the initial review, should be ready for another pass. |
|
Changes Unknown when pulling 6f0b2a2 on praekeltfoundation:feature/junebug-channel into ** on rapidpro:master**. |
|
Thanks! 🍰 Will you merge and if not, please let me know what else is expected from me :) |
|
We will need a signed CAA from you before merging.
…On Jan 30, 2017 7:49 AM, "Simon de Haan" ***@***.***> wrote:
Thanks! 🍰
Will you merge and if not, please let me know what else is expected from
me :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#435 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKQgzmBV1Up7PPl_sF1P-kekIhWv46mks5rXdw8gaJpZM4LxMgm>
.
|
|
Cool, working on this internally. |
|
Submitted via email |
| @@ -0,0 +1,20 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Just merged from us because the migration squashing wasn't on /rapidpro yet and redoing that wasn't in the cards. Shouldn't affect this PR except that this migration should be 0058 and depend on 0057
Fixed merge conflict between 'claim_junebug' and 'facebook_whitelist'
|
I'll look into the coverage drop. |
|
@nicpottier changes applied, ready for re-review. |
|
Great, will merge this today. Does Junebug have a squarish logo we can use on the channel claim page? If so I'll add this to the font icon set so it can be all pretty-like. (need something square in a vector format, svg would be best) |
|
We've got https://github.com/praekelt/junebug-marketing/blob/master/html/img/junebug-logo.svg but that's not quite square. I'm checking to see if we have something square. |
|
Nice ya that would work if maybe we just had the Jun squiggle piece? |
|
Merged this just to get it in (since we are moving super quick right now) but would still love the squiggle and will work that in if you get it to me! |
I've taken the Jasmin channel as an example and have modelled the Junebug channel along the same lines.
As Junebug can support both SMS and USSD in the same channel type I suspect more work is required here to get this to work as a USSD channel in RapidPro.
This should be enough to get it to work with SMS.