Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Conda recipes to {{ stdlib('c') }} #39

Closed
jakirkham opened this issue Apr 17, 2024 · 5 comments
Closed

Migrate Conda recipes to {{ stdlib('c') }} #39

jakirkham opened this issue Apr 17, 2024 · 5 comments
Assignees

Comments

@jakirkham
Copy link
Member

jakirkham commented Apr 17, 2024

The sysroot* syntax used currently by RAPIDS recipes is getting phased out

Sample syntax as seen currently in librmm:

recipe/meta.yaml:

    - sysroot_{{ target_platform }} {{ sysroot_version }}

recipe/conda_build_config.yaml:

sysroot_version:
  - "2.17"

The recommendation is to move to {{ stdlib('c') }} ( conda-forge/conda-forge.github.io#2102 )

Changes would look something like this

recipe/meta.yaml:

-    - sysroot_{{ target_platform }} {{ sysroot_version }}
+    - {{ stdlib('c') }}

recipe/conda_build_config.yaml:

-sysroot_version:
+c_stdlib_version:
  - "2.17"

Raising this issue to track making these changes in RAPIDS

@bdice
Copy link
Contributor

bdice commented Apr 17, 2024

@jakirkham This seems like an easy change to automate for conda recipes. Let me know if I should work on that.

What should be done about sysroot packages in dependencies.yaml?

https://github.com/rapidsai/rmm/blob/9e6db746f1a4a6361fb9fadf381f749dc52faaea/dependencies.yaml#L91

@jakirkham jakirkham changed the title Migrate Conda recipes to {{ stdlib("c") }} Migrate Conda recipes to {{ stdlib('c') }} Apr 17, 2024
@jakirkham
Copy link
Member Author

jakirkham commented Apr 17, 2024

Yep seems like a good rapids-reviser task. Could also be a good learning opportunity potentially

Are those just being used in environment files? If so, that seems ok to keep. The sysroot package still exists. It is just we are changing the recipe specification

Also spelled out the changes a bit more above

@jameslamb
Copy link
Member

@hcho3 I've assigned this to you here since you've been working on it.

@jakirkham
Copy link
Member Author

Bradley and I reviewed. We think they look good

Asking OPS for a review. That will likely happen early next week

If OPS approves, we can merge

rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #224
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #15594
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #731
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #371
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue May 6, 2024
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #93
rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #164
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #4374
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #2278
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #594
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this issue May 6, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #1376
@jakirkham
Copy link
Member Author

These are all now merged. Closing as complete

Thanks Hyunsu for the PRs and everyone for the reviews! 🙏

difyrrwrzd added a commit to difyrrwrzd/cuvs that referenced this issue Aug 10, 2024
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai/cuvs#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants