Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov installation #62

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

ajschmidt8
Copy link
Member

#61 added an explicit TARGETPLATFORM build argument, which broke our CI images.

TARGETPLATFORM is a build argument provided by docker build automatically: https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope.

`TARGETPLATFORM` is a build argument provided by `docker build` automatically: https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope.
@ajschmidt8
Copy link
Member Author

The TARGETPLATFORM argument is used to install codecov below:

  • ci-imgs/Dockerfile

    Lines 87 to 106 in c1eedba

    # Install codecov binary
    RUN \
    case "${TARGETPLATFORM}" in \
    "linux/amd64") \
    CODECOV_VERSION=v0.3.2 \
    && curl https://uploader.codecov.io/verification.gpg --max-time 10 --retry 5 \
    | gpg --no-default-keyring --keyring trustedkeys.gpg --import \
    && curl -Os --max-time 10 --retry 5 https://uploader.codecov.io/${CODECOV_VERSION}/linux/codecov \
    && curl -Os --max-time 10 --retry 5 https://uploader.codecov.io/${CODECOV_VERSION}/linux/codecov.SHA256SUM \
    && curl -Os --max-time 10 --retry 5 https://uploader.codecov.io/${CODECOV_VERSION}/linux/codecov.SHA256SUM.sig \
    && gpgv codecov.SHA256SUM.sig codecov.SHA256SUM \
    && shasum -a 256 -c codecov.SHA256SUM \
    && chmod +x codecov \
    && mv codecov /usr/local/bin \
    && rm -f codecov* \
    ;; \
    *) \
    echo 'Codecov is only supported on "linux/amd64" machines'; \
    ;; \
    esac

@ajschmidt8 ajschmidt8 merged commit 65bb863 into rapidsai:main Aug 22, 2023
153 checks passed
@ajschmidt8 ajschmidt8 deleted the fix-codecov branch August 22, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant