Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23.12 nightly wheels missing Python minor version #641

Closed
jakirkham opened this issue Nov 29, 2023 · 1 comment · Fixed by #643 or #644
Closed

23.12 nightly wheels missing Python minor version #641

jakirkham opened this issue Nov 29, 2023 · 1 comment · Fixed by #643 or #644
Labels
bug Something isn't working
Milestone
v23.12.00

Comments

@jakirkham
Copy link
Member

jakirkham commented Nov 29, 2023 •
edited
Loading

Currently the cuCIM 23.12 nightly wheels are showing up as if they are Python 3 universal wheels. Please see the screenshots below

cucim-cu12: Screenshot 2023-11-28 at 5 50 54 PM
cucim-cu11: Screenshot 2023-11-28 at 5 50 40 PM

However they have strict Python version dependence, which is not being reflected

Basically this is a consequence of the wheels being treated as pure when they are not

Would be good to correct this somehow
@jakirkham jakirkham added the bug Something isn't working label Nov 29, 2023
@jakirkham jakirkham added this to the v23.12.00 milestone Nov 29, 2023
This was referenced Nov 29, 2023
Closed
Closed
Closed
Closed
@jakirkham
Copy link
Member Author

This SO answer gave a nice summary of potential options

This was referenced Nov 29, 2023
Merged
Merged
Open
@rapids-bot rapids-bot bot closed this as completed in #644 Nov 29, 2023
rapids-bot bot pushed a commit that referenced this issue Nov 29, 2023
@jakirkham
Retag wheels to be cpXY (#644)
12ec30b 
Fixes #641

After building the wheels, this...

* Creates the tag string from `cp` (CPython) and the `python`'s version
* Uses the tag string to replace the `python_tag` and `abi_tag`
* Removes the previous wheels while performing this conversion
* Hands them to `auditwheel` for final steps

Authors:
  - https://github.com/jakirkham

Approvers:
  - Gregory Lee (https://github.com/grlee77)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)

URL: #644
raydouglass pushed a commit that referenced this issue Dec 11, 2023
@jakirkham
Inform setuptools that Extensions are included (#643)
23e3f1c 
Fixes #641

As `setuptools`/`pip`/`wheel` will mark our package as pure (even though we put an extension module into it), make sure it doesn't by informing `setuptools` that `Extensions` are contained within. This should ensure that are wheels include the Python minor version they were built for.

Authors:
   - https://github.com/jakirkham

Approvers:
   - Ray Douglass (https://github.com/raydouglass)
   - Bradley Dice (https://github.com/bdice)
   - Vyas Ramasubramani (https://github.com/vyasr)
   - Gregory Lee (https://github.com/grlee77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
cucim
Status: Done
Milestone
v23.12.00
1 participant
@jakirkham