fix failing regionprops test cases #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes regionprops test failures seen recently on CI and locally
grlee77
added
bug
gigony
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Looks good to me but somehow there are code style issues on this line
./src/cucim/skimage/measure/_regionprops.py:316:81: E501 line too long (85 > 80 characters)
There are other issues with isort but ignored by CI/CD.
https://gpuci.gpuopenanalytics.com/blue/organizations/jenkins/rapidsai%2Fgpuci%2Fcucim%2Fprb%2Fcucim-style/detail/cucim-style/65/pipeline
Style formatting the changed code to pass flake8 tests
|
Thanks @grlee77 |
quasiben
approved these changes
Sep 29, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the regionprops test failures seen recently on CI. Seems related to #4354, but not sure why the prior fix no longer works.
The image is always boolean, so a cast to uint8 should be a safe.
cc @gigony