Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize zoom out implementation with separate padding kernel #125

Merged
merged 8 commits into from
Nov 21, 2021
Merged

Optimize zoom out implementation with separate padding kernel #125

merged 8 commits into from
Nov 21, 2021

Conversation

chirayuG-nvidia
Copy link
Contributor

Optimizing zoom-out image transform with work efficient padding kernel. Changes are simple on python side, existing unit tests will suffice and are passing.

CC: @shekhardw @gigony

@chirayuG-nvidia chirayuG-nvidia requested a review from a team as a code owner October 11, 2021 08:07
@chirayuG-nvidia chirayuG-nvidia added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 11, 2021
@shekhardw
Copy link
Contributor

@chirayuG-nvidia
Changes look good to me. Approving from my side. It will be good if you can add test case for zoom out. Current test case only covers zoom in.

@chirayuG-nvidia
Copy link
Contributor Author

@shekhardw thanks for the review. Added unit test for this case.

@chirayuG-nvidia chirayuG-nvidia changed the title [Review] Optimize zoom out implementation with separate padding kernel Optimize zoom out implementation with separate padding kernel Nov 8, 2021
@chirayuG-nvidia
Copy link
Contributor Author

@jakirkham can you please review and merge this PR?

grlee77
grlee77 approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I notice one apparently unused variable in the new kernel

python/cucim/src/cucim/core/operations/intensity/kernel/cuda_kernel_source.py Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 05e81dd into branch-21.12 Nov 21, 2021
@jakirkham jakirkham deleted the cgarg_optimize_zoomout_padding branch November 21, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhardw shekhardw shekhardw approved these changes

@grlee77 grlee77 grlee77 approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@chirayuG-nvidia chirayuG-nvidia

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chirayuG-nvidia @shekhardw @jakirkham @grlee77