Fix GDS link in Jupyter notebook #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gigony
commented
Oct 27, 2021
gigony
commented
- Update Jupyter notebook to include the correct GDS link -- https://developer.nvidia.com/gpudirect-storage
quasiben
approved these changes
Oct 27, 2021
jakirkham
reviewed
Oct 27, 2021
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| ### Notebooks | |||
|
|
|||
| Please check out our [Welcome](notebooks/Welcome.ipynb) notebook ([NBViewer](https://nbviewer.jupyter.org/github/rapidsai/cucim/blob/branch-21.06/notebooks/Welcome.ipynb)) | |||
| Please check out our [Welcome](notebooks/Welcome.ipynb) notebook ([NBViewer](https://nbviewer.jupyter.org/github/rapidsai/cucim/blob/branch-21.12/notebooks/Welcome.ipynb)) | |||
There was a problem hiding this comment.
Maybe we should add this to the update script?
There was a problem hiding this comment.
Good idea!
Will update in a separate PR.
There was a problem hiding this comment.
Pushed PR for that: #132
gigony
commented
Oct 27, 2021
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| ### Notebooks | |||
|
|
|||
| Please check out our [Welcome](notebooks/Welcome.ipynb) notebook ([NBViewer](https://nbviewer.jupyter.org/github/rapidsai/cucim/blob/branch-21.06/notebooks/Welcome.ipynb)) | |||
| Please check out our [Welcome](notebooks/Welcome.ipynb) notebook ([NBViewer](https://nbviewer.jupyter.org/github/rapidsai/cucim/blob/branch-21.12/notebooks/Welcome.ipynb)) | |||
There was a problem hiding this comment.
Good idea!
Will update in a separate PR.
jakirkham
approved these changes
Oct 27, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
Follow-up change for #131 (comment) . `branch-${CURRENT_MAJOR}.${CURRENT_MINOR}` => `branch-${NEXT_MAJOR}.${NEXT_MINOR}` in README.md Authors: - Gigon Bae (https://github.com/gigony) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.