Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter notebook for SVS Support #147

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

gigony
Copy link
Contributor

@gigony gigony commented Nov 10, 2021

  • Update notebooks/Welcome.ipynb
  • Add notebooks/Supporting_Aperio_SVS_Format.ipynb to show loading Aperio SVS images

@gigony gigony added the doc Improvements or additions to documentation label Nov 10, 2021
@gigony gigony added this to the v21.12.00 milestone Nov 10, 2021
@gigony gigony self-assigned this Nov 10, 2021
@gigony gigony changed the title Add Jupyter notebook for SVS Support. Add Jupyter notebook for SVS Support Nov 10, 2021
@jakirkham
Copy link
Member

rerun tests

@gigony gigony added the non-breaking Introduces a non-breaking change label Nov 17, 2021
@jakirkham
Copy link
Member

jakirkham commented Nov 18, 2021

There's some commented code in the notebook like

#         start_loc_data = [(sx, sy)
...

Should we drop that?

Edit: Also wonder if we should break the Experiment Code section out into a script

@gigony
Copy link
Contributor Author

gigony commented Nov 20, 2021

There's some commented code in the notebook like

#         start_loc_data = [(sx, sy)
...

Should we drop that?

Edit: Also wonder if we should break the Experiment Code section out into a script

Good idea! Thank you for the suggestion. Moved as scripts and removed unnecessary comments.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e3ce50d into rapidsai:branch-21.12 Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants