Upgrade Numpy to 1.18 for Python 3.9 support #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
jjacobelli
added
improvement
grlee77
approved these changes
Jan 19, 2022
ajschmidt8
reviewed
Jan 19, 2022
There was a problem hiding this comment.
Let's get @jakirkham to take a look at this also. I know he pinned to 1.17 in #148. Just want to make sure this version bump is okay.
jakirkham
approved these changes
Jan 19, 2022
Yep this is totally fine. Actually happy to see 1.17 go away. For context we need to pin during the build since we link to NumPy's C API. At runtime this simply forms a lower bound on what NumPy version is supported. So as long as we are moving the rest of RAPIDS to NumPy 1.18, this makes sense. HTH 🙂 |
|
@gpucibot merge |
quasiben
approved these changes
Jan 19, 2022
|
@Ethyling I think we need you to merge directly and not with gpucibot |
|
Or does this still need an OPS review? |
ajschmidt8
approved these changes
Jan 19, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
Following #196, it seems like Numpy 1.18 is not enough for Python 3.9 and we need to upgrade to Numpy 1.19 Authors: - Jordan Jacobelli (https://github.com/Ethyling) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Python 3.9, we need to have
numpy >= 1.18