Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing cucim.skimage.segmentation.clear_border function #267

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 20, 2022

closes #266

This PR provides the missing clear_border function from the segmentation module. This is a straightforward adaption of the scikit-image function, mainly swapping numpy->cupy.

I put the v22.04.01 tag since this does fix a bug with the function having previously been listed in __all__ despite being missing, but waiting until 22.06 seems okay if that is preferred.

@grlee77 grlee77 added bug Something isn't working feature request New feature or request labels Apr 20, 2022
@grlee77 grlee77 added this to the v22.04.01 milestone Apr 20, 2022
@grlee77 grlee77 requested a review from a team as a code owner April 20, 2022 11:15
@grlee77 grlee77 added non-breaking Introduces a non-breaking change and removed bug Something isn't working labels Apr 20, 2022
@alxndrkalinin
Copy link
Contributor

@grlee77 any updates on this? Seems like a small non-breaking fix that'd be easy to merge.

@grlee77 grlee77 modified the milestones: v22.04.01, v22.06.00 May 12, 2022
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grlee77 Looks good to me!

@gigony
Copy link
Contributor

gigony commented May 17, 2022

@alxndrkalinin Our next release would be v22.06.00 (around June 6th. We are skipping v22.04.01 release this time) and this PR is likely to be part of v22.06.00.

I just built a test package from this PR and you may be able to use it until we release v22.06.00.

Thank you!

pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ cucim==0.0.267

@alxndrkalinin
Copy link
Contributor

Thanks @gigony! This is great. Any chance #272 can also be reviewed in time for 22.06?
Both issues came up within the same project I'm working on, so would be fantastic to have a build that includes both.

@gigony
Copy link
Contributor

gigony commented May 17, 2022

Thanks @gigony! This is great. Any chance #272 can also be reviewed in time for 22.06? Both issues came up within the same project I'm working on, so would be fantastic to have a build that includes both.

Yes, @grlee77 would help review your PR(#272) and we would like to include your PR as part of v22.06.00 release. Thank you so much for your contribution!

On top of #267, I have added changes in #272 to provide you PyPI package that you can use until we release v22.06.00.

pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ cucim==0.0.272

@alxndrkalinin
Copy link
Contributor

Awesome, thanks @gigony!

Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jakirkham jakirkham self-requested a review May 24, 2022 06:12
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Greg! 🙏 Couple questions below

@jakirkham
Copy link
Member

@gpucibot merge

1 similar comment
@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3807dd6 into rapidsai:branch-22.06 Jun 1, 2022
@jakirkham
Copy link
Member

Thanks Greg! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cucim.skimage.segmentation.clear_border is exported in __init__.py but not implemented
4 participants