-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing cucim.skimage.segmentation.clear_border
function
#267
Conversation
@grlee77 any updates on this? Seems like a small non-breaking fix that'd be easy to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grlee77 Looks good to me!
@alxndrkalinin Our next release would be v22.06.00 (around June 6th. We are skipping v22.04.01 release this time) and this PR is likely to be part of v22.06.00. I just built a test package from this PR and you may be able to use it until we release v22.06.00. Thank you! pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ cucim==0.0.267 |
Yes, @grlee77 would help review your PR(#272) and we would like to include your PR as part of v22.06.00 release. Thank you so much for your contribution! On top of #267, I have added changes in #272 to provide you PyPI package that you can use until we release v22.06.00. pip install --force-reinstall --extra-index-url https://test.pypi.org/simple/ cucim==0.0.272 |
Awesome, thanks @gigony! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Greg! 🙏 Couple questions below
Co-authored-by: Gigon Bae <gigony@gmail.com>
@gpucibot merge |
1 similar comment
@gpucibot merge |
Thanks Greg! 🙏 |
closes #266
This PR provides the missing
clear_border
function from the segmentation module. This is a straightforward adaption of the scikit-image function, mainly swapping numpy->cupy.I put the v22.04.01 tag since this does fix a bug with the function having previously been listed in
__all__
despite being missing, but waiting until 22.06 seems okay if that is preferred.