Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom compiler environment variables #307

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Remove custom compiler environment variables #307

merged 1 commit into from
Jun 21, 2022

Conversation

ajschmidt8
Copy link
Member

With the PR below merged, we no longer set the CUDAHOSTCXX variable in any of our CI images. This PR cleans up some references to CUDAHOSTCXX.

@ajschmidt8 ajschmidt8 requested a review from a team as a code owner June 7, 2022 15:48
@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 7, 2022
@jakirkham
Copy link
Member

rerun tests

gigony
gigony approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c0feac3 into rapidsai:branch-22.08 Jun 21, 2022
@ajschmidt8 ajschmidt8 deleted the rm-compiler-vars branch June 21, 2022 19:01
@jakirkham
Copy link
Member

Thanks AJ! 🙏

gigony added a commit to gigony/cucim that referenced this pull request Aug 2, 2022
@gigony
Revert "Remove custom compiler environment variables (rapidsai#307)"
88c5f11 
This reverts commit c0feac3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevagh sevagh sevagh approved these changes

@jakirkham jakirkham jakirkham approved these changes

@gigony gigony gigony approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajschmidt8 @jakirkham @gigony @sevagh