Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unimplemented functions from See Also and fix version numbers in deprecation warnings #356

Merged
merged 2 commits into from
Jul 28, 2022
Merged

remove unimplemented functions from See Also and fix version numbers in deprecation warnings #356

merged 2 commits into from
Jul 28, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 28, 2022 •
edited
Loading

closes #325

TODO:

  • update DeprecationWarning strings

@grlee77 grlee77 added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Jul 28, 2022
@grlee77
Copy link
Contributor Author

grlee77 commented Jul 28, 2022

removes references to functions unavailable in cuCIM

@grlee77
update DeprecationWarnings so they mention cuCIM version numbers
31e214b 
I set the deprecations that were introduced in 22.02 or earlier in the 2023.02 release.
We can't gaurantee this won't be earlier than upstream scikit-image, but I think
it is still okay even if not. Certainly this is better than referring to upstream version
numbers!
@grlee77 grlee77 marked this pull request as ready for review July 28, 2022 18:15
@grlee77 grlee77 requested a review from a team as a code owner July 28, 2022 18:15
@grlee77 grlee77 changed the title remove unimplemented functions from See Also sections remove unimplemented functions See Also and fix version numbers in deprecation warnings Jul 28, 2022
@grlee77 grlee77 changed the title remove unimplemented functions See Also and fix version numbers in deprecation warnings remove unimplemented functions from See Also and fix version numbers in deprecation warnings Jul 28, 2022
@grlee77
Copy link
Contributor Author

grlee77 commented Jul 28, 2022

The deprecations labeled as '0.19' were introduced here in 22.02.00 so I changed those to that. For those that said they were completing at version "1.0" I set it to "23.02.00".

@grlee77 grlee77 added this to the v22.08.00 milestone Jul 28, 2022
@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3befda7 into rapidsai:branch-22.08 Jul 28, 2022
@jakirkham
Copy link
Member

Thanks Greg! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
v22.08.00
Development

Successfully merging this pull request may close these issues.

[DOC] audit See Also sections of docs and update deprecation warning strings
2 participants
@grlee77 @jakirkham