Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for scikit-image functions introduced in 22.08 #378

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Aug 3, 2022

This PR adds benchmarks for a few of the recently introduced functions.

It also uses more realistic nD label object generation for the segmentation benchmarks.

omit functions only taking binary input from floating point tests in run-nv-bench-morphology.sh
refactor LabelBench and LabelAndImageBench to generate more realistic labels
(previously 3D was not being handled properly)
@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 3, 2022
@grlee77
Copy link
Contributor Author

grlee77 commented Aug 3, 2022

no need to immediately review this for the 22.08 release since we don't ship the benchmark scripts

@grlee77 grlee77 added this to the v22.10.00 milestone Aug 3, 2022
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg!
Looks good to me.

@gigony
Copy link
Contributor

gigony commented Oct 5, 2022

@gpucibot merge

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 92fa67e into rapidsai:branch-22.10 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants