Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dockcross and pybind11 #519

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Upgrade dockcross and pybind11 #519

merged 3 commits into from
Apr 5, 2023

Conversation

gigony
Copy link
Contributor

@gigony gigony commented Feb 21, 2023 •
edited by grlee77
Loading

Upgrade dockcross image version to support Python 3.10+ for PyPI Wheels.

new Dockcross image: dockcross/manylinux2014-x64:20230215-2dd9a1c
new pybind11 version: v2.10.3

Upgrading pybind11 was needed to build Python 3.11+ wheels (compilation error with old pybind11 library).

The latest dockcross image supports gcc10 and --override option was needed to install https://developer.download.nvidia.com/compute/cuda/11.0.3/local_installers/cuda_11.0.3_450.51.06_linux.run (to ignore unrecognized compiler versions) in the dockcross image.

# Build cuda-enabled dev container from `dockcross/manylinux2014-x64:20230215-2dd9a1c` image
./run build_manylinux2014
# Build Python package
./run build_package # using build_python_package is also okay but it wouldn't remove `dist` folder before building.

# wheel file is available in `dist` folder.

With this change, wheel file can support Python 3.6~3.11

@gigony gigony added the improvement Improves an existing functionality label Feb 21, 2023
@gigony gigony added this to the v23.04.00 milestone Feb 21, 2023
@gigony gigony requested a review from grlee77 February 21, 2023 22:52
@gigony gigony requested a review from a team as a code owner February 21, 2023 22:52
@gigony gigony self-assigned this Feb 21, 2023
@grlee77 grlee77 added the non-breaking Introduces a non-breaking change label Feb 22, 2023
@jakirkham
Copy link
Member

Thanks Gigon! 🙏

@gigony gigony force-pushed the upgrade_dockcross_pybind11 branch from dda1656 to 1e5e9fd Compare March 8, 2023 05:46
@gigony gigony requested review from a team as code owners April 4, 2023 19:22
grlee77
grlee77 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

For some reason a couple of changes previously merged in #521 show up here.
edit: resolved after merging latest branch-23.04

python/cucim/src/cucim/skimage/_vendored/_ndimage_filters.py Outdated Show resolved Hide resolved
python/cucim/src/cucim/skimage/filters/tests/test_median.py Outdated Show resolved Hide resolved
@grlee77
Copy link
Contributor

grlee77 commented Apr 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit b51be3a into rapidsai:branch-23.04 Apr 5, 2023
@grlee77
Copy link
Contributor

grlee77 commented Apr 5, 2023

Thanks @gigony!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grlee77 grlee77 grlee77 approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

@quasiben quasiben quasiben approved these changes

Assignees

@gigony gigony

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
cucim
Status: Done
Milestone
v23.04.00
Development

Successfully merging this pull request may close these issues.
5 participants
@gigony @jakirkham @grlee77 @quasiben @raydouglass