Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GCC 11 #522

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Update to GCC 11 #522

merged 1 commit into from
Mar 6, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 28, 2023

This PR updates builds to use GCC 11.

@bdice bdice marked this pull request as ready for review February 28, 2023 23:00
@bdice bdice requested a review from a team as a code owner February 28, 2023 23:00
@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 1, 2023
@bdice
Copy link
Contributor Author

bdice commented Mar 2, 2023

Please do not merge until all RAPIDS repos are ready to migrate. (I do not have privileges to add the DO NOT MERGE label to prohibit merging.)

@raydouglass
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit c16ec7e into rapidsai:branch-23.04 Mar 6, 2023
@jakirkham
Copy link
Member

Thanks Bradley and everyone for reviewing! 🙏

Noticed there are a couple spots where we have GCC 9 still. Should we update these too (cc @gigony who may have thoughts here)?

* `gcc` version 9.0+

## Local Development using Conda Environment (for gcc 9.x and nvcc 11.0.x)

- gcc_linux-aarch64=9.*

gcc-9 \
g++-9 \

# Setup gcc-9
RUN update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-7 10 \
&& update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-9 20 \
&& update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-7 10 \
&& update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-9 20

# Note that library had a failure with nvcc compiler and gcc 9.x headers
# ...c++/9/tuple(553): error: pack "_UElements" does not have the same number of elements as "_Elements"
# __and_<is_nothrow_assignable<_Elements&, _UElements>...>::value;
# Not using nvcc for main code that uses cli11 solved the issue.

@bdice
Copy link
Contributor Author

bdice commented Mar 7, 2023

I’ll fix dependencies.yaml.

I didn’t want to touch the Dockerfiles without discussing (and forgot to mention it here, sorry). I wasn’t sure how those are used or tested.

As for the contributing guide, the package should still build with GCC 9 for now, so I leave it to your discretion on whether we update the minimum required version.

@bdice bdice mentioned this pull request Mar 7, 2023
@gigony
Copy link
Contributor

gigony commented Mar 8, 2023

Thanks Bradley and everyone for reviewing! pray

Noticed there are a couple spots where we have GCC 9 still. Should we update these too (cc @gigony who may have thoughts here)?

* `gcc` version 9.0+

## Local Development using Conda Environment (for gcc 9.x and nvcc 11.0.x)

- gcc_linux-aarch64=9.*

gcc-9 \
g++-9 \

# Setup gcc-9
RUN update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-7 10 \
&& update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-9 20 \
&& update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-7 10 \
&& update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-9 20

# Note that library had a failure with nvcc compiler and gcc 9.x headers
# ...c++/9/tuple(553): error: pack "_UElements" does not have the same number of elements as "_Elements"
# __and_<is_nothrow_assignable<_Elements&, _UElements>...>::value;
# Not using nvcc for main code that uses cli11 solved the issue.

As @bdice mentioned, I think updating dependencies.yaml would be enough for now.

cucim/docker/Dockerfile-cmake is not used by RAPIDS CI/CD so it's okay to leave as it is.

This file(
cucim/cpp/plugins/cucim.kit.cumed/cmake/deps/cli11.cmake) is also okay to leave as it is.

rapids-bot bot pushed a commit that referenced this pull request Mar 8, 2023
This PR updates aarch64 dependencies to use GCC 11. Follow-up to #522.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Gigon Bae (https://github.com/gigony)
  - Jordan Jacobelli (https://github.com/jjacobelli)

URL: #524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants