-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GCC 11 #522
Update to GCC 11 #522
Conversation
Please do not merge until all RAPIDS repos are ready to migrate. (I do not have privileges to add the DO NOT MERGE label to prohibit merging.) |
/merge |
Thanks Bradley and everyone for reviewing! 🙏 Noticed there are a couple spots where we have GCC 9 still. Should we update these too (cc @gigony who may have thoughts here)? Line 86 in c16ec7e
Line 108 in c16ec7e
Line 61 in c16ec7e
Lines 51 to 52 in c16ec7e
Lines 68 to 72 in c16ec7e
cucim/cpp/plugins/cucim.kit.cumed/cmake/deps/cli11.cmake Lines 38 to 41 in c16ec7e
|
I’ll fix dependencies.yaml. I didn’t want to touch the Dockerfiles without discussing (and forgot to mention it here, sorry). I wasn’t sure how those are used or tested. As for the contributing guide, the package should still build with GCC 9 for now, so I leave it to your discretion on whether we update the minimum required version. |
As @bdice mentioned, I think updating dependencies.yaml would be enough for now. cucim/docker/Dockerfile-cmake is not used by RAPIDS CI/CD so it's okay to leave as it is. This file( |
This PR updates aarch64 dependencies to use GCC 11. Follow-up to #522. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Gigon Bae (https://github.com/gigony) - Jordan Jacobelli (https://github.com/jjacobelli) URL: #524
This PR updates builds to use GCC 11.